From 8467102662160ce1d41ccc3160d0125447decce1 Mon Sep 17 00:00:00 2001 From: Jonas 'Sortie' Termansen Date: Sun, 15 Jul 2018 13:30:23 +0200 Subject: [PATCH] Fix ls(1) not checking stat_record()'s error correctly. --- utils/ls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/ls.c b/utils/ls.c index fc3900c6..9f7f7045 100644 --- a/utils/ls.c +++ b/utils/ls.c @@ -814,7 +814,7 @@ static int ls_directory(int parentfd, const char* relpath, const char* path) memset(record, 0, sizeof(*record)); if ( !(record->dirent = dirent_dup(entry)) ) err(1, "malloc"); - if ( stat_record(dir, path, record) < 0 ) + if ( !stat_record(dir, path, record) ) ret = 1; record->no_recurse = isdotdot; }